Phil Sutter <phil@xxxxxx> wrote: > > How did you generate it? The added code is pure voodoo magic to me, > > so I wonder if we can just remove the 'test for -t in iptables-restore > > files' code. > > Sorry, I didn't mean to create such unreadable code. I guess after > managing to wrap my head around to understand the old code, the new one > seemed much more clear to me. ;) Fair enough, my main point was where the test cases come from, i.e. did you see such rule dumps in the wild, or did you create this manually to catch all corner cases? I see you have a test for things like "-?t", so I wondered where that came from. > What do you think? Or should I respin after adding a bunch of comments > to is_table_param() to make it more clear? I think thats the best option, I don't have any objections at the check per se given older iptables does this too.
