Re: [PATCH net] netfilter: conntrack: avoid possible false sharing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/9/19 9:24 PM, Jakub Kicinski wrote:
> On Wed,  9 Oct 2019 09:19:13 -0700, Eric Dumazet wrote:
>> As hinted by KCSAN, we need at least one READ_ONCE()
>> to prevent a compiler optimization.
>>
>> More details on :
>> https://github.com/google/ktsan/wiki/READ_ONCE-and-WRITE_ONCE#it-may-improve-performance
>>
>> [...]
>>
>> Fixes: cc16921351d8 ("netfilter: conntrack: avoid same-timeout update")
>> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
>> Reported-by: syzbot <syzkaller@xxxxxxxxxxxxxxxx>
>> Cc: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
>> Cc: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>
>> Cc: Florian Westphal <fw@xxxxxxxxx>
> 
> Applied, thank you. 
> 
> Not queuing for stable, please let me know if I should.
> 

This is fine really, thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux