On Mon, Oct 07, 2019 at 10:08:28PM +0200, Kadlecsik József wrote: > Hi Jeremy, Pablo, > > On Thu, 3 Oct 2019, Jeremy Sowden wrote: > > > In his feedback on an earlier patch series [0], Pablo suggested reducing > > the number of ipset static inline functions. > > > > 0 - https://lore.kernel.org/netfilter-devel/20190808112355.w3ax3twuf6b7pwc7@salvia/ > > > > This series: > > > > * removes inline from static functions in .c files; > > * moves some static functions out of headers and removes inline from > > them if they are only called from one .c file, > > * moves some static functions out of headers, removes inline from them > > and makes them extern if they are too big. > > > > The changes reduced the size of the ipset modules by c. 13kB, when > > compiled with GCC 9 on x86-64. > > I have reviewed all of the patches and they are all right. Pablo, could > you queue them for nf-next? I applied the patches in the ipset git tree. Sure. > Acked-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx> Applied, thanks a lot Jozsef.
