Re: [PATCH libnetfilter_queue] src: Enable clang build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 25, 2019 at 12:28:12PM +1000, Duncan Roe wrote:
> On Tue, Sep 24, 2019 at 01:11:29PM +0100, Jeremy Sowden wrote:
> > On 2019-09-22, at 10:10:31 +1000, Duncan Roe wrote:
> > > Unlike gcc, clang insists to have EXPORT_SYMBOL(x) come before the definition
> > > of x. So move all EXPORT_SYMBOL lines to just after the last #include line.
> > >
> > > pktbuff.c was missing its associated header, so correct that as well.
> > >
> > > gcc & clang produce different warnings. gcc warns that nfq_set_verdict_mark is
> > > deprecated while clang warns of invalid conversion specifier 'Z' at
> > > src/extra/ipv6.c:138 (should that be lower-case?)
> >
> > It should, yes.
> >
> > J.
>
> Will send a v2 then.
>
> Cheers ... Duncan.

On second thoughts, will send a separate 1-liner patch for 5z as time permits.

Cheers ... Duncan.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux