On Thu, Sep 26, 2019 at 10:05:58AM +1000, Duncan Roe wrote: > On Wed, Sep 25, 2019 at 03:14:19PM +0200, Fernando Fernandez Mancera wrote: > > Currently clang requires EXPORT_SYMBOL() to be above the function > > implementation. At the same time doxygen is not generating the proper > > documentation because of that. > > > > This patch solves that problem but EXPORT_SYMBOL looks less like the Linux > > kernel way exporting symbols. > > > > Reported-by: Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> > > Signed-off-by: Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx> > > --- > > src/attr.c | 145 +++++++++++++++++++++---------------------------- > > src/callback.c | 14 ++--- > > src/internal.h | 3 +- > > src/nlmsg.c | 68 +++++++++-------------- > > src/socket.c | 42 ++++++-------- > > 5 files changed, 113 insertions(+), 159 deletions(-) > > > > Why do we need EXPORT_SYMBOL anyway? For __attribute__((visibility("default"))).