Re: [nft PATCH v2] parser_bison: Fix 'exists' keyword on Big Endian

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phil Sutter <phil@xxxxxx> wrote:
> Size value passed to constant_expr_alloc() must correspond with actual
> data size, otherwise wrong portion of data will be taken later when
> serializing into netlink message.
> 
> Booleans require really just a bit, but make type of boolean_keys be
> uint8_t (introducing new 'val8' name for it) and pass the data length
> using sizeof() to avoid any magic numbers.
> 
> While being at it, fix len value in parser_json.c as well although it
> worked before due to the value being rounded up to the next multiple of
> 8.

Looks good, thanks Phil.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux