Re: [nft PATCH] parser_bison: Fix 'exists' keyword on Big Endian

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Sep 13, 2019 at 05:35:49PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@xxxxxx> wrote:
> > -					   BYTEORDER_HOST_ENDIAN, 1, buf);
> > +					   BYTEORDER_HOST_ENDIAN,
> > +					   sizeof(char) * BITS_PER_BYTE, buf);
> 
> You can omit the sizeof(char), its always 1.  Otherwise this loooks good to me.

OK, I'll send a v2.

Thanks, Phil



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux