Re: [PATCH nftables 3/3] src: mnl: retry when we hit -ENOBUFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Garver <eric@xxxxxxxxxxx> wrote:
> > +			if (errno == ENOBUFS && enobuf_restarts++ < 3) {
> > +				scale *= 2;
> > +				goto restart;
> > +			}
> 
> If this restart is triggered it causes rules to be duplicated. We send
> the same batch again.

Right :-(

> I'm hitting this on x86_64. Maybe we need find a better way to estimate
> the rcvbuffer in the case of --echo. By the time we see ENOBUFS we're
> already in a bad way - events have already be lost.

Thats correct.  Pablo, I don't see a way for dynamic probing, as Eric
explains the error occurs after the fact so we cannot recover.

I will send a best-effort fix in a bit.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux