On Sat, Sep 07, 2019 at 08:16:59PM +0100, Jeremy Sowden wrote: > On 2019-09-04, at 21:05:35 +0200, Pablo Neira Ayuso wrote: [...] > > * 17/30 I don't think struct nf_bridge_frag_data qualifies for the > > global netfilter.h header. > > What about netfilter_bridge.h? That's fine indeed. [...] > As I mentioned in the cover-letter the idea behind my approach was to > config out as much code as possible: if header H is only required when > config C is enabled, then wrap it in an `#if IS_ENABLED(CONFIG_C)`. > However, you're clearly not keen, and, having had a poke around in other > headers that have been moved off the blacklist, I've come to the con- > clusion that it was the wrong way to go: we want less #ifdeffery, not > more. Will rework this part of the series. It would be great if all those are #if IS_ENABLED(CONFIG_C) only to make happy CONFIG_HEADER_TEST go away, and no more new ones are added indeed. Thanks.
