Re: [PATCH nf-next v2 30/30] netfilter: wrap headers in CONFIG checks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jeremy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Jeremy-Sowden/Add-config-option-checks-to-netfilter-headers/20190903-075100
base:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-randconfig-s0-09021303 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from security/apparmor/lsm.c:23:0:
   include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag':
>> include/linux/netfilter_ipv6.h:132:9: error: implicit declaration of function 'nf_ct_frag6_gather'; did you mean 'nf_ct_attach'? [-Werror=implicit-function-declaration]
     return nf_ct_frag6_gather(net, skb, user);
            ^~~~~~~~~~~~~~~~~~
            nf_ct_attach
   cc1: some warnings being treated as errors

vim +132 include/linux/netfilter_ipv6.h

c9bb6165a16e6d Pablo Neira Ayuso 2019-05-31  120  
764dd163ac922f Pablo Neira Ayuso 2019-05-29  121  static inline int nf_ipv6_br_defrag(struct net *net, struct sk_buff *skb,
764dd163ac922f Pablo Neira Ayuso 2019-05-29  122  				    u32 user)
764dd163ac922f Pablo Neira Ayuso 2019-05-29  123  {
764dd163ac922f Pablo Neira Ayuso 2019-05-29  124  #if IS_MODULE(CONFIG_IPV6)
764dd163ac922f Pablo Neira Ayuso 2019-05-29  125  	const struct nf_ipv6_ops *v6_ops = nf_get_ipv6_ops();
764dd163ac922f Pablo Neira Ayuso 2019-05-29  126  
764dd163ac922f Pablo Neira Ayuso 2019-05-29  127  	if (!v6_ops)
764dd163ac922f Pablo Neira Ayuso 2019-05-29  128  		return 1;
764dd163ac922f Pablo Neira Ayuso 2019-05-29  129  
764dd163ac922f Pablo Neira Ayuso 2019-05-29  130  	return v6_ops->br_defrag(net, skb, user);
43a38c3f318082 Arnd Bergmann     2019-06-17  131  #elif IS_BUILTIN(CONFIG_IPV6)
764dd163ac922f Pablo Neira Ayuso 2019-05-29 @132  	return nf_ct_frag6_gather(net, skb, user);
43a38c3f318082 Arnd Bergmann     2019-06-17  133  #else
43a38c3f318082 Arnd Bergmann     2019-06-17  134  	return 1;
764dd163ac922f Pablo Neira Ayuso 2019-05-29  135  #endif
764dd163ac922f Pablo Neira Ayuso 2019-05-29  136  }
764dd163ac922f Pablo Neira Ayuso 2019-05-29  137  

:::::: The code at line 132 was first introduced by commit
:::::: 764dd163ac922f8683b5bcd3007251ce7b26cd33 netfilter: nf_conntrack_bridge: add support for IPv6

:::::: TO: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux