Re: [PATCH nft v8 2/2] meta: Introduce new conditions 'time', 'day' and 'hour'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 23, 2019 at 09:08:47AM +0200, Ander Juaristi wrote:
> On 21/8/19 23:04, Florian Westphal wrote:
> > > > 
> > > > Pablo, please see this "-t" option -- should be just re-use -n instead?
> > > > 
> > > > Other than this, this patch looks good and all tests pass for me.
> > > 
> > > this should be printed numerically with -n (global switch to disable
> > > literal printing).
> > > 
> > > Then, -t could be added for disabling literal in a more fine grain, as
> > > Phil suggest time ago with other existing options that are similar to
> > > this one.
> > 
> > Ander, would you mind respinning this once more and excluding the -t
> > option?  You can reuse -n (OPT_NUMERIC) to print raw time values for
> > the time being.
> > 
> 
> You mean removing the -t option altogether?

Phil likes having fine grain knobs. I (as a user) particularly prefer
the global -n switch, but I also see value in those fine grain knobs.

Anyway, I let you choose on this one.

Thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux