Hi Thomas, On Wed, Aug 21, 2019 at 04:14:28PM +0200, Thomas Jarosch wrote: > The find_pattern() debug output was printing the 'skip' character. > This can be a NULL-byte and messes up further pr_debug() output. > > Output without the fix: > kernel: nf_conntrack_ftp: Pattern matches! > kernel: nf_conntrack_ftp: Skipped up to `<7>nf_conntrack_ftp: find_pattern `PORT': dlen = 8 > kernel: nf_conntrack_ftp: find_pattern `EPRT': dlen = 8 > > Output with the fix: > kernel: nf_conntrack_ftp: Pattern matches! > kernel: nf_conntrack_ftp: Skipped up to 0x0 delimiter! > kernel: nf_conntrack_ftp: Match succeeded! > kernel: nf_conntrack_ftp: conntrack_ftp: match `172,17,0,100,200,207' (20 bytes at 4150681645) > kernel: nf_conntrack_ftp: find_pattern `PORT': dlen = 8 Do you use this debugging? I haven't use it for years. Asking because an alternative patch would be to remove this.
