Re: [PATCH] netfilter: xt_physdev: Fix spurious error message in physdev_mt_check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Todd Seidelmann <tseidelmann@xxxxxxxxxx> wrote:
> Simplify the check in physdev_mt_check() to emit an error message
> only when passed an invalid chain (ie, NF_INET_LOCAL_OUT).
> This avoids cluttering up the log with errors against valid rules.
> 
> For large/heavily modified rulesets, current behavior can quickly
> overwhelm the ring buffer, because this function gets called on
> every change, regardless of the rule that was changed.

Agreed, we've had this notice long enough, better to only
print it when we reject the rule.

Acked-by: Florian Westphal <fw@xxxxxxxxx>



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux