Re: [PATCH nft 2/2] src: secmark: fix missing quotes in selctx strings output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Jallot <ejallot@xxxxxxxxx> wrote:
> Colon is not allowed in strings and breaks nft -f.
> So move to quoted string in selctx output.
> 
> Before patch:
>  # nft list ruleset > rules.nft; cat rules.nft
>  table inet t {
>          secmark s {
>                  system_u:object_r:ssh_server_packet_t:s0
>          }
>  }
>  # nft flush ruleset
>  # nft -f rules.nft
>  rules.nft:3:11-11: Error: syntax error, unexpected colon
>                 system_u:object_r:ssh_server_packet_t:s0
>                         ^
> 
> After patch:
>  # nft list ruleset > rules.nft; cat rules.nft
>  table inet t {
>          secmark s {
>                  "system_u:object_r:ssh_server_packet_t:s0"
>          }
>  }
>  # nft flush ruleset
>  # nft -f rules.nft
> 
> Fixes: 3bc84e5c ("src: add support for setting secmark")
> Signed-off-by: Eric Jallot <ejallot@xxxxxxxxx>

Thanks for the patches.  Something has mangled them in transit,
replacing tabs with spaces and adding line breaks.

I've applied this change manually and pushed the result out,
can you please double-check the result is correct?

If not, please submit a relative fix.

Thanks!



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux