Michael Braun <michael-dev@xxxxxxxxxxxxx> wrote: > Currently, there is no vlan information (e.g. when used with a vlan aware > bridge) passed to userspache, HWHEADER will contain an 08 00 (ip) suffix > even for tagged ip packets. > > Therefore, add an extra netlink attribute that passes the vlan information > to userspace similarly to 15824ab29f for nfqueue. > > Signed-off-by: Michael Braun <michael-dev@xxxxxxxxxxxxx> > > -- > v2: mirror nfqueue behaviour Thanks, looks good with one minor detail, see below. > /* This is an inline function, we don't really care about a long > * list of arguments */ > static inline int > @@ -580,6 +614,12 @@ __build_packet_message(struct nfnl_log_net *log, > NFULA_CT, NFULA_CT_INFO) < 0) > goto nla_put_failure; In nfulnl_log_packet(), you will need to add to "size" calculation, i.e. += nla_total_size(0) /* nested */ += nla_total_size(sizef(u16)) /* id */ += nla_total_size(sizef(u16)) /* tag */ Furthermore (Unrelated to your patch), I think that the end of __build_packet_message() (error handling) lacks a call to nlmsg_cancel(). The printk could be removed and replaced by a WARN_ON_ONCE, it should never be hit.
