On Mon, 19 Aug 2019 07:26:07 +0000, Vlad Buslov wrote: > On Fri 16 Aug 2019 at 20:56, Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote: > > Hi Vlad! > > > > While looking into this, would you mind also add the missing > > flow_block_cb_is_busy() calls in the indirect handlers in the drivers? > > > > LMK if you're too busy, I don't want this to get forgotten :) > > Hi Jakub, > > I've checked the code and it looks like only nfp driver is affected: > > - I added check in nfp to lookup cb_priv with > nfp_flower_indr_block_cb_priv_lookup() and call > flow_block_cb_is_busy() if cb_priv exists. > > - In mlx5 en_rep.c there is already a check that indr_priv exists, so > trying to lookup block_cb->cb_indent==indr_priv is redundant. > > - Switch drivers (mlxsw and ocelot) take reference to block_cb on > FLOW_BLOCK_BIND, so they should not require any modifications. > > Tell me if I missed anything. Sending the patch for nfp. Ah, that sounds plausible, I've only checked the nfp driver.
