On Mon, Aug 12, 2019 at 06:50:09PM +0100, Edward Cree wrote: > On 09/07/2019 21:55, Pablo Neira Ayuso wrote: > > This patch updates flow_block_cb_setup_simple() to use the flow block API. > > Several drivers are also adjusted to use it. > > > > This patch introduces the per-driver list of flow blocks to account for > > blocks that are already in use. > > > > Remove tc_block_offload alias. > > > > Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > > --- > > v4: fix typo in list in nfp driver - Jakub Kicinski. > > Move driver_list handling to the driver code, this list is transitional, > > until drivers are updated to support multiple subsystems. No more > > driver_list handling from core. > > Pablo, can you explain (because this commit message doesn't) why these per- > driver lists are needed, and what the information/state is that has module > (rather than, say, netdevice) scope? The idea is to update drivers to support one flow_block per subsystem, one for ethtool, one for tc, and so on. So far, existing drivers only allow for binding one single flow_block to one of the existing subsystems. So this limitation applies at driver level.