On 2019-08-13, at 12:14:03 +0200, Pablo Neira Ayuso wrote: > On Tue, Aug 13, 2019 at 11:04:24AM +0100, Jeremy Sowden wrote: > > On 2019-08-13, at 11:55:29 +0200, Pablo Neira Ayuso wrote: > > > Would you mind if - before pushing this out - I do this string > > > replacement for the patch subject? > > > > > > s/added/add > > > s/removed/remove > > > s/inlined/inline > > > > > > I was told present tense is preferred for description. Otherwise, I'll > > > leave them as is. > > > > I adopted past tenses because at the point at which one is reading > > the description of a commit, one is usually reading about old > > behaviour and what has been done to change it. However, I wasn't > > aware that there was a preference and I am happy to switch to the > > present tense instead, so by all means feel free to change them. > > This is not in the Documentation tree, or I could not find this in a > quick git grep: > > https://kernelnewbies.org/PatchPhilosophy > > "In patch descriptions and in the subject, it is common and preferable > to use present-tense, imperative language. Write as if you are telling > git what to do with your patch." > > I remember though that maintainers have been asking for this in the > past. Thanks for the pointer. J.
Attachment:
signature.asc
Description: PGP signature
