From: David Miller <davem@xxxxxxxxxxxxx>
Date: Fri, 09 Aug 2019 12:37:41 -0700 (PDT)
> From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> Date: Tue, 6 Aug 2019 18:03:08 +0200
>
>> This patchset contains two updates for the flow_offload users:
>>
>> 1) Pass the major tc priority to drivers so they do not have to
>> lshift it. This is a preparation patch for the fix coming in
>> patch #2.
>>
>> 2) Set the hardware priority from the netfilter basechain priority,
>> some drivers break when using the existing hardware priority
>> number that is set to zero.
>
> Series applied.
Sorry, I had to revert:
[davem@localhost net]$ make -s -j14
In file included from ./include/linux/list.h:9,
from ./include/linux/module.h:9,
from net/netfilter/nf_tables_offload.c:3:
net/netfilter/nf_tables_offload.c: In function ʽnft_chain_offload_priorityʼ:
./include/linux/kernel.h:269:23: warning: overflow in conversion from ʽshort intʼ to ʽsigned charʼ changes value from ʽ-32768ʼ to ʽ0ʼ [-Woverflow]
({ signed type __x = (x); __x < 0 ? -__x : __x; }), other)
^
./include/linux/kernel.h:256:16: note: in expansion of macro ʽ__abs_choose_exprʼ
#define abs(x) __abs_choose_expr(x, long long, \
^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:257:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, long, \
^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:258:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, int, \
^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:259:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, short, \
^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:260:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, char, \
^~~~~~~~~~~~~~~~~
net/netfilter/nf_tables_offload.c:134:35: note: in expansion of macro ʽabsʼ
return basechain->ops.priority + abs(SHRT_MIN);
^~~
./include/linux/kernel.h:263:31: warning: overflow in conversion from ʽshort intʼ to ʽsigned charʼ changes value from ʽ-32768ʼ to ʽ0ʼ [-Woverflow]
(char)({ signed char __x = (x); __x<0?-__x:__x; }), \
^
./include/linux/kernel.h:269:54: note: in definition of macro ʽ__abs_choose_exprʼ
({ signed type __x = (x); __x < 0 ? -__x : __x; }), other)
^~~~~
./include/linux/kernel.h:257:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, long, \
^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:258:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, int, \
^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:259:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, short, \
^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:260:3: note: in expansion of macro ʽ__abs_choose_exprʼ
__abs_choose_expr(x, char, \
^~~~~~~~~~~~~~~~~
net/netfilter/nf_tables_offload.c:134:35: note: in expansion of macro ʽabsʼ
return basechain->ops.priority + abs(SHRT_MIN);
^~~
