Re: [PATCH] netfilter: nft_dynset: support for element deletion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ander,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc3 next-20190808]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ander-Juaristi/netfilter-nft_dynset-support-for-element-deletion/20190714-122358
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   net/netfilter/nft_dynset.c: In function 'nft_dynset_eval':
>> net/netfilter/nft_dynset.c:115:2: error: expected ';' before '}' token
     } else {
     ^

vim +115 net/netfilter/nft_dynset.c

   106	
   107	void nft_dynset_eval(const struct nft_expr *expr,
   108			     struct nft_regs *regs, const struct nft_pktinfo *pkt)
   109	{
   110		const struct nft_dynset *priv = nft_expr_priv(expr);
   111		struct nft_set *set = priv->set;
   112	
   113		if (priv->op == NFT_DYNSET_OP_DELETE) {
   114			set->ops->delete(set, &regs->data[priv->sreg_key])
 > 115		} else {
   116			if (nft_dynset_update(priv->sreg_key, priv->op, priv->timeout, expr, pkt, regs, set)) {
   117				if (priv->invert)
   118					regs->verdict.code = NFT_BREAK;
   119				return;
   120			}
   121	
   122			if (!priv->invert)
   123				regs->verdict.code = NFT_BREAK;
   124		}
   125	}
   126	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux