On 2019-08-08, at 13:23:55 +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 07, 2019 at 03:16:58PM +0100, Jeremy Sowden wrote: > [...] > > +/* Called from uadd only, protected by the set spinlock. > > + * The kadt functions don't use the comment extensions in any way. > > + */ > > +static inline void > > +ip_set_init_comment(struct ip_set *set, struct ip_set_comment *comment, > > + const struct ip_set_ext *ext) > > Not related to this patch, but I think the number of inline functions > could be reduced a bit by exporting symbols? Specifically for > functions that are called from the netlink control plane, ie. _uadd() > functions. I think forcing the compiler to inline this is not useful. > This could be done in a follow up patchset. I'll take a look. J.
Attachment:
signature.asc
Description: PGP signature
