Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_tables-store-data-in-offload-context-registers/20190804-160102 base: https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=sh If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): net/netfilter/nf_tables_offload.c: In function 'nft_flow_rule_create': >> net/netfilter/nf_tables_offload.c:73:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ vim +73 net/netfilter/nf_tables_offload.c c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 30 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 31 struct nft_flow_rule *nft_flow_rule_create(const struct nft_rule *rule) c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 32 { c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 33 struct nft_offload_ctx ctx = { c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 34 .dep = { c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 35 .type = NFT_OFFLOAD_DEP_UNSPEC, c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 36 }, c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 37 }; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 38 struct nft_flow_rule *flow; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 39 int num_actions = 0, err; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 40 struct nft_expr *expr; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 41 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 42 expr = nft_expr_first(rule); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 43 while (expr->ops && expr != nft_expr_last(rule)) { c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 44 if (expr->ops->offload_flags & NFT_OFFLOAD_F_ACTION) c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 45 num_actions++; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 46 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 47 expr = nft_expr_next(expr); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 48 } c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 49 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 50 flow = nft_flow_rule_alloc(num_actions); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 51 if (!flow) c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 52 return ERR_PTR(-ENOMEM); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 53 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 54 expr = nft_expr_first(rule); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 55 while (expr->ops && expr != nft_expr_last(rule)) { c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 56 if (!expr->ops->offload) { c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 57 err = -EOPNOTSUPP; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 58 goto err_out; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 59 } c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 60 err = expr->ops->offload(&ctx, flow, expr); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 61 if (err < 0) c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 62 goto err_out; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 63 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 64 expr = nft_expr_next(expr); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 65 } c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 66 flow->proto = ctx.dep.l3num; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 67 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 68 return flow; c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 69 err_out: c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 70 nft_flow_rule_destroy(flow); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 71 c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 72 return ERR_PTR(err); c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 @73 } c9626a2cbdb20e Pablo Neira Ayuso 2019-07-09 74 :::::: The code at line 73 was first introduced by commit :::::: c9626a2cbdb20e26587b3fad99960520a023432b netfilter: nf_tables: add hardware offload support :::::: TO: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> :::::: CC: David S. Miller <davem@xxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
