Re: [PATCH nf-next v3 3/9] netfilter: nft_fwd_netdev: add fw_netdev action support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/netfilter-nf_tables_offload-support-more-expr-and-obj-offload/20190804-144846
base:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   net/netfilter/nft_fwd_netdev.c: In function 'nft_fwd_netdev_offload':
>> net/netfilter/nft_fwd_netdev.c:73:36: error: 'struct nft_offload_reg' has no member named 'data'
     const struct nft_data *data = &reg->data;
                                       ^~

vim +73 net/netfilter/nft_fwd_netdev.c

    66	
    67	static int nft_fwd_netdev_offload(struct nft_offload_ctx *ctx,
    68					  struct nft_flow_rule *flow,
    69					  const struct nft_expr *expr)
    70	{
    71		const struct nft_fwd_netdev *priv = nft_expr_priv(expr);
    72		struct nft_offload_reg *reg = &ctx->regs[priv->sreg_dev];
  > 73		const struct nft_data *data = &reg->data;
    74		struct flow_action_entry *entry;
    75		struct net_device *dev;
    76		int oif = -1;
    77	
    78		entry = &flow->rule->action.entries[ctx->num_actions++];
    79	
    80		memcpy(&oif, data->data, sizeof(oif));
    81		dev = __dev_get_by_index(ctx->net, oif);
    82		if (!dev)
    83			return -EOPNOTSUPP;
    84	
    85		entry->id = FLOW_ACTION_REDIRECT;
    86		entry->dev = dev;
    87	
    88		return 0;
    89	}
    90	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux