Ander Juaristi <a@xxxxxxxxxxxx> wrote:
>
>
> On 2/8/19 9:12, Ander Juaristi wrote:
> > diff --git a/include/uapi/linux/netfilter/nf_tables.h b/include/uapi/linux/netfilter/nf_tables.h
> > index 82abaa183fc3..6d9dd120b466 100644
> > --- a/include/uapi/linux/netfilter/nf_tables.h
> > +++ b/include/uapi/linux/netfilter/nf_tables.h
> > @@ -799,6 +799,9 @@ enum nft_exthdr_attributes {
> > * @NFT_META_OIFKIND: packet output interface kind name (dev->rtnl_link_ops->kind)
> > * @NFT_META_BRI_IIFPVID: packet input bridge port pvid
> > * @NFT_META_BRI_IIFVPROTO: packet input bridge vlan proto
> > + * @NFT_META_TIME: a UNIX timestamp
> > + * @NFT_META_TIME_DAY: day of week
> > + * @NFT_META_TIME_HOUR: hour of day
> > */
> > enum nft_meta_keys {
> > NFT_META_LEN,
> > @@ -829,8 +832,9 @@ enum nft_meta_keys {
> > NFT_META_SECPATH,
> > NFT_META_IIFKIND,
> > NFT_META_OIFKIND,
> > - NFT_META_BRI_IIFPVID,
> > - NFT_META_BRI_IIFVPROTO,
>
> I needed to remove these two so that the next three constants take the
> correct values (otherwise it won't work because the meta keys sent by
> userspace and those expected by the kernel don't match).
This breaks the build.
> Those two constants NFT_META_BRI_IIFPVID and NFT_META_BRI_IIFVPROTO aren't
> defined in nftables, I don't know why.
The userspace patch has not been applied yet, only the kernel one.
You can include a pre-patch in your series that adds the enums.
"sync meta keys with kernel" or similar.
