Re: [nft PATCH v2 0/2] parser_bison: Get rid of (most) bison compiler warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 23, 2019 at 03:23:11PM +0200, Phil Sutter wrote:
> Eliminate as many bison warnings emitted since bison-3.3 as possible.
> Sadly getting bison, flex and automake right is full of pitfalls so on
> one hand this series does not fix for deprecated %name-prefix statement
> and on the other passes -Wno-yacc to bison to not complain about POSIX
> incompatibilities although automake causes to run bison in POSIX compat
> mode in the first place. Fixing either of those turned out to be
> non-trivial.

Indeed, lots of warnings and things to be updated.

Do you think it's worth fixing those in the midterm?

We can just place these two small ones in the tree, I'm just concerned
about tech debt in the midterm, these deprecated stuff might just go
away.

Thanks.

> Changes since v1:
> - Drop nfnl_osf patch, Fernando took care of that already.
> - Split remaining patch in two.
> - Document which warnings are being silenced.
> 
> Phil Sutter (2):
>   parser_bison: Fix for deprecated statements
>   src: Call bison with -Wno-yacc to silence warnings
> 
>  src/Makefile.am    | 2 +-
>  src/parser_bison.y | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> -- 
> 2.22.0
> 



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux