Re: [PATCH iptables] nfnl_osf: fix snprintf -Wformat-truncation warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



El 23 de julio de 2019 21:26:43 CEST, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> escribió:
>On Sun, Jul 21, 2019 at 09:24:15PM +0200, Fernando Fernandez Mancera
>wrote:
>> Fedora 30 uses very recent gcc (version 9.1.1 20190503 (Red Hat
>9.1.1-1)),
>> osf produces following warnings:
>> 
>> -Wformat-truncation warning have been introduced in the version 7.1
>of gcc.
>> Also, remove a unneeded address check of "tmp + 1" in
>nf_osf_strchr().
>
>nfnl_osf.c: In function ‘osf_load_line’:
>nfnl_osf.c:372:14: error: ‘subtype’ undeclared (first use in this
>function)
>  372 |   i = sizeof(subtype);
>      |              ^~~~~~~
>
>Hitting this here after this patch.

I am sorry, this is a typo. It should be "f.subtype". I am going to send a v2. Sorry for the inconveniences.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux