Re: [iptables PATCH v2 00/11] Larger xtables-save review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phil Sutter <phil@xxxxxx> wrote:
> This series started as a fix to program names mentioned in *-save
> outputs and ended in merging ebtables-save and arptables-save code into
> xtables_save_main used by ip{6,}tables-nft-save.
> 
> The first patch is actually unrelated but was discovered when testing
> counter output - depending on environment, ebtables-nft might segfault.
> 
> The second patch fixes option '-c' of ebtables-nft-save which enables
> counter prefixes in dumped rules but failed to disable the classical
> ebtables-style counters.
> 
> Patch three unifies the header/footer comments in all the *-save tools
> and also drops the extra newline printed in ebtables- and arptables-save
> output, so test scripts need adjustments beyond dropping the new comment
> lines from output.
> 
> Patch four fixes the table compatibility check in ip{6,}tables-nft-save.
> 
> Patches five and seven to nine prepare for integrating arptables- and
> ebtables-save into the xtables-save code.
> 
> Patch six merely fixes a minor coding-style issue.
> 
> Patches ten and eleven finally perform the actual merge.
> 
> Changes since v1:
> - Rebased onto current master branch.
> - Improved commit message in patch eight.

Thanks, this looks good to me.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux