This series started as a fix to program names mentioned in *-save outputs and ended in merging ebtables-save and arptables-save code into xtables_save_main used by ip{6,}tables-nft-save. The first patch is actually unrelated but was discovered when testing counter output - depending on environment, ebtables-nft might segfault. The second patch fixes option '-c' of ebtables-nft-save which enables counter prefixes in dumped rules but failed to disable the classical ebtables-style counters. Patch three sorts program names quoted in output of any of the *-save programs, patch four unifies the header/footer comments in the same. The latter also drops the extra newline printed in ebtables- and arptables-save output, so test scripts need adjustments beyond dropping the new comment lines from output. Patch five fixes the table compatibility check in ip{6,}tables-nft-save. Patches six and eight to ten prepare for integrating arptables- and ebtables-save into the xtables-save code. Patch seven merely fixes a minor coding-style issue. Patches eleven and twelve finally perform the actual merge. Phil Sutter (12): ebtables: Fix error message for invalid parameters ebtables-save: Fix counter formatting xtables-save: Use argv[0] as program name xtables-save: Unify *-save header/footer comments xtables-save: Fix table compatibility check nft: Make nft_for_each_table() more versatile xtables-save: Avoid mixed code and declarations xtables-save: Pass optstring/longopts to xtables_save_main() xtables-save: Make COMMIT line optional xtables-save: Pass format flags to do_output() arptables-save: Merge into xtables_save_main() ebtables-save: Merge into xtables_save_main() iptables/nft-bridge.c | 39 +-- iptables/nft.c | 6 +- iptables/nft.h | 2 +- .../arptables/0001-arptables-save-restore_0 | 7 +- .../0002-arptables-restore-defaults_0 | 6 +- .../arptables/0003-arptables-verbose-output_0 | 5 +- .../ebtables/0002-ebtables-save-restore_0 | 4 +- .../ebtables/0003-ebtables-restore-defaults_0 | 6 +- .../testcases/ebtables/0004-save-counters_0 | 64 +++++ iptables/xtables-eb.c | 4 +- iptables/xtables-save.c | 242 ++++-------------- 11 files changed, 146 insertions(+), 239 deletions(-) create mode 100755 iptables/tests/shell/testcases/ebtables/0004-save-counters_0 -- 2.22.0