From: David Miller <davem@xxxxxxxxxxxxx>
Date: Thu, 18 Jul 2019 12:39:39 -0700 (PDT)
> Series applied, thank you.
Actually, I had to revert, this breaks the build:
In file included from ./include/net/netfilter/nf_tables_offload.h:4,
from <command-line>:
./include/net/flow_offload.h: In function ʽflow_block_cb_addʼ:
./include/net/flow_offload.h:297:2: error: implicit declaration of function ʽlist_add_tailʼ [-Werror=implicit-function-declaration]
list_add_tail(&block_cb->list, &offload->cb_list);
^~~~~~~~~~~~~
./include/net/flow_offload.h: In function ʽflow_block_cb_removeʼ:
./include/net/flow_offload.h:303:2: error: implicit declaration of function ʽlist_moveʼ [-Werror=implicit-function-declaration]
list_move(&block_cb->list, &offload->cb_list);
^~~~~~~~~
./include/net/flow_offload.h: In function ʽflow_block_initʼ:
./include/net/flow_offload.h:346:2: error: implicit declaration of function ʽINIT_LIST_HEADʼ; did you mean ʽXATTR_LIST_MAXʼ? [-Werror=implicit-function-declaration]
INIT_LIST_HEAD(&flow_block->cb_list);
^~~~~~~~~~~~~~
XATTR_LIST_MAX
In file included from ./include/net/netfilter/nf_tables.h:5,
from ./include/net/netfilter/nf_tables_offload.h:5,
from <command-line>:
./include/linux/list.h: At top level:
./include/linux/list.h:26:20: warning: conflicting types for ʽINIT_LIST_HEADʼ
static inline void INIT_LIST_HEAD(struct list_head *list)
^~~~~~~~~~~~~~
./include/linux/list.h:26:20: error: static declaration of ʽINIT_LIST_HEADʼ follows non-static declaration
In file included from ./include/net/netfilter/nf_tables_offload.h:4,
from <command-line>:
./include/net/flow_offload.h:346:2: note: previous implicit declaration of ʽINIT_LIST_HEADʼ was here
INIT_LIST_HEAD(&flow_block->cb_list);
^~~~~~~~~~~~~~
In file included from ./include/net/netfilter/nf_tables.h:5,
from ./include/net/netfilter/nf_tables_offload.h:5,
from <command-line>:
./include/linux/list.h:91:20: warning: conflicting types for ʽlist_add_tailʼ
static inline void list_add_tail(struct list_head *new, struct list_head *head)
^~~~~~~~~~~~~
./include/linux/list.h:91:20: error: static declaration of ʽlist_add_tailʼ follows non-static declaration
In file included from ./include/net/netfilter/nf_tables_offload.h:4,
from <command-line>:
./include/net/flow_offload.h:297:2: note: previous implicit declaration of ʽlist_add_tailʼ was here
list_add_tail(&block_cb->list, &offload->cb_list);
^~~~~~~~~~~~~
In file included from ./include/net/netfilter/nf_tables.h:5,
from ./include/net/netfilter/nf_tables_offload.h:5,
from <command-line>:
./include/linux/list.h:199:20: warning: conflicting types for ʽlist_moveʼ
static inline void list_move(struct list_head *list, struct list_head *head)
^~~~~~~~~
./include/linux/list.h:199:20: error: static declaration of ʽlist_moveʼ follows non-static declaration
In file included from ./include/net/netfilter/nf_tables_offload.h:4,
from <command-line>:
./include/net/flow_offload.h:303:2: note: previous implicit declaration of ʽlist_moveʼ was here
list_move(&block_cb->list, &offload->cb_list);
^~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:304: include/net/netfilter/nf_tables_offload.h.s] Error 1
make: *** [Makefile:1077: include] Error 2
make: *** Waiting for unfinished jobs....
