On Thu, Jul 18, 2019 at 05:13:12PM +0200, Phil Sutter wrote:
> Hi,
>
> On Thu, Jul 18, 2019 at 05:05:16PM +0200, Pablo Neira Ayuso wrote:
> > On Thu, Jul 18, 2019 at 02:44:09PM +0200, Phil Sutter wrote:
> > > Don't hard-code program names. This also fixes for bogus 'xtables-save'
> > > name which is no longer used.
> >
> > Applied, thanks Phil.
> >
> > BTW, it seems arptables-save doesn't print:
> >
> > # Generated by ...
>
> Also, ip{,6}tables-save prints that line once per table while
> ebtables-save does it once for all. And theres:
>
> | # Completed on ...
>
> which neither arp- nor ebtables-save print.
>
> > for some reason, probably good to get this consistent with other
> > existing -save tools.
>
> We can assume lines starting with '#' are ignored by any potential
> parser of any family's dump files, right?
Yes. It's just a comment. I just think it would be good to fix these
small inconsistencies at some point.
Thanks!
