Re: [PATCH nf] netfilter: nf_tables: don't fail when updating base chain policy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 13, 2019 at 11:59:21PM +0200, Florian Westphal wrote:
> The following nftables test case fails on nf-next:
> 
> tests/shell/run-tests.sh tests/shell/testcases/transactions/0011chain_0
> 
> The test case contains:
> add chain x y { type filter hook input priority 0; }
> add chain x y { policy drop; }"
> 
> The new test
> if (chain->flags ^ flags)
> 	return -EOPNOTSUPP;
> 
> triggers here, because chain->flags has NFT_BASE_CHAIN set, but flags
> is 0 because no flag attribute was present in the policy update.
> 
> Just fetch the current flag settings of a pre-existing chain in case
> userspace did not provide any.

Applied, thanks for fixing up this, this is my fault.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux