On Tue, Jul 16, 2019 at 02:56:09AM +0900, Masahiro Yamada wrote: > On Tue, Jul 16, 2019 at 2:33 AM Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > > > On Mon, Jul 15, 2019 at 07:28:04PM +0200, Laura Garcia wrote: > > > CC'ing netfilter. > > > > > > On Mon, Jul 15, 2019 at 6:45 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > > > > > > > On 7/14/19 9:48 PM, Stephen Rothwell wrote: > > > > > Hi all, > > > > > > > > > > Please do not add v5.4 material to your linux-next included branches > > > > > until after v5.3-rc1 has been released. > > > > > > > > > > Changes since 20190712: > > > > > > > > > > > > > Hi, > > > > > > > > I am seeing these build errors from HEADERS_TEST (or KERNEL_HEADERS_TEST) > > > > for include/net/netfilter/nf_tables_offload.h.s: > > > > > > > > CC include/net/netfilter/nf_tables_offload.h.s > > [...] > > > > Should this header file not be tested? > > This means you must endlessly exclude > headers that include nf_tables.h > > > > Yes, it should indeed be added. > > Adding 'header-test-' is the last resort. OK, so policy now is that all internal headers should compile standalone, right? I can have a look and make it compile standalone.