On Mon, Jul 15, 2019 at 01:28:08AM +0200, Florian Westphal wrote: > Ander Juaristi <a@xxxxxxxxxxxx> wrote: > > This patch introduces meta matches in the kernel for time (a UNIX timestamp), > > day (a day of week, represented as an integer between 0-6), and > > hour (an hour in the current day, or: number of seconds since midnight). > > > > All values are taken as unsigned 64-bit integers. > > > > The 'time' keyword is internally converted to nanoseconds by nft in > > userspace, and hence the timestamp is taken in nanoseconds as well. > > I think this is conceptually fine, thanks Ander. > > Can you run this throuch scripts/checkpatch.pl and fix up the style > nits? > > > + case NFT_META_TIME_HOUR: > > + len = sizeof(u64); > > As in my other comment, I think this can be u32. Florian requested changes, so please follow up on this one and send v3. BTW, I thought you agreed to stick to u32 (second resolution) for this patch. If you decide to go for u64, then get_unaligned() is missing in your patch, just like in nft_byteorder.c.
