Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on nf-next/master] url: https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/netfilter-nf_nat_proto-add-nf_nat_bridge_ops-support/20190709-070304 base: https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master config: x86_64-randconfig-s1-07091425 (attached as .config) compiler: gcc-7 (Debian 7.4.0-9) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): net/netfilter/nf_nat_proto.c: In function 'nf_nat_bridge_in': >> net/netfilter/nf_nat_proto.c:1048:10: error: implicit declaration of function 'nf_nat_ipv6_in'; did you mean 'nf_nat_ipv4_in'? [-Werror=implicit-function-declaration] return nf_nat_ipv6_in(priv, skb, state); ^~~~~~~~~~~~~~ nf_nat_ipv4_in net/netfilter/nf_nat_proto.c: In function 'nf_nat_bridge_out': >> net/netfilter/nf_nat_proto.c:1062:10: error: implicit declaration of function 'nf_nat_ipv6_out'; did you mean 'nf_nat_ipv4_out'? [-Werror=implicit-function-declaration] return nf_nat_ipv6_out(priv, skb, state); ^~~~~~~~~~~~~~~ nf_nat_ipv4_out cc1: some warnings being treated as errors vim +1048 net/netfilter/nf_nat_proto.c 1038 1039 #if defined(CONFIG_NF_TABLES_BRIDGE) && IS_ENABLED(CONFIG_NFT_NAT) 1040 static unsigned int 1041 nf_nat_bridge_in(void *priv, struct sk_buff *skb, 1042 const struct nf_hook_state *state) 1043 { 1044 switch (skb->protocol) { 1045 case htons(ETH_P_IP): 1046 return nf_nat_ipv4_in(priv, skb, state); 1047 case htons(ETH_P_IPV6): > 1048 return nf_nat_ipv6_in(priv, skb, state); 1049 default: 1050 return NF_ACCEPT; 1051 } 1052 } 1053 1054 static unsigned int 1055 nf_nat_bridge_out(void *priv, struct sk_buff *skb, 1056 const struct nf_hook_state *state) 1057 { 1058 switch (skb->protocol) { 1059 case htons(ETH_P_IP): 1060 return nf_nat_ipv4_out(priv, skb, state); 1061 case htons(ETH_P_IPV6): > 1062 return nf_nat_ipv6_out(priv, skb, state); 1063 default: 1064 return NF_ACCEPT; 1065 } 1066 } 1067 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
