Re: [PATCH nftables v4 1/1] add ct expectations support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I was going to apply this, but I just noticed a problem.

json compilation breaks:

parser_json.c: In function ‘json_parse_cmd_add_object’:
parser_json.c:2993:20: error: ‘value’ undeclared (first use in this function)
   if (!json_unpack(value, "{s:o}", "dport", &tmp))
                    ^~~~~

Please, make sure you run ./configure with --with-json.

Also run:

        tests/py# python nft-tests.py -j

to run json tests.

Would you fix this and revamp? I would like that json support is a bit
taken as a first class citizen, so Phil does not have to run after
every new patch updating the json bits to fix it :-).

Thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux