On Thu, Jun 27, 2019 at 6:22 PM Eric Garver <eric@xxxxxxxxxxx> wrote: > > On Fri, Jun 21, 2019 at 11:10:53PM +0530, Shekhar Sharma wrote: > > This patch adds the netns feature to the nft-test.py file. > > > > Signed-off-by: Shekhar Sharma <shekhar250198@xxxxxxxxx> > > --- > > The global variable 'netns' stores the value of args.netns > > which is used as an argument in various functions. > > > > The version history of the patch is : > > v1: add the netns feature > > v2: use format() method to simplify print statements. > > v3: updated the shebang > > v4: resent the same with small changes > > v5&v6: resent with small changes > > v7: netns commands changed for passing the netns name via netns argument. > > v8: correct typo error > > v9: use tempfile, replace cmp() and add a global variable 'netns' > > and store the args.netns value in it. > > > > There should be a separator (---) after the revision history and before > the actual patch. > i.e. > > --- > Okay. > This patch has hunks from your other patch "[PATCH nft v9]tests: py: fix > pyhton3". Please keep the changes separate. Yes i have included the changes for converting to python3 and also included the netns feature. Should i send a patch without any changes for python3 and only changes for the netns feature? Shekhar
