Arturo Borrero Gonzalez <arturo@xxxxxxxxxxxxx> wrote: > On 6/27/19 12:50 PM, Arturo Borrero Gonzalez wrote: > > They are not part of the libnftables library API, they are not public symbols, > > so it doesn't not make sense to have them there. Move the two functions to a > > different source file. > > > > Signed-off-by: Arturo Borrero Gonzalez <arturo@xxxxxxxxxxxxx> > > --- > > src/libnftables.c | 27 --------------------------- > > src/utils.c | 26 ++++++++++++++++++++++++++ > > 2 files changed, 26 insertions(+), 27 deletions(-) > > > > This patch is probably not required, it does not affect how visible the symbols > of the library are. > > Drop it or apply it, I'm fine either way. I'd be inclinded to skip because of the nft_ prefix (and removing that adds useless code churn), provided patch 3 is accepted of course.