On Fri, Jun 21, 2019 at 07:16:03PM +0200, Jiri Pirko wrote: > Thu, Jun 20, 2019 at 09:49:09PM CEST, pablo@xxxxxxxxxxxxx wrote: > > [...] > > > > >+static LIST_HEAD(tcf_block_cb_list); > > I still don't like the global list. Have to go throught the code more > carefully, but why you can't pass the priv/ctx from tc/netfilter. From > tc it would be tcf_block as it is now, from netfilter something else. This tcf_block_cb_list should go away at some point, once drivers know how to deal with multiple subsystems using the setup block infrastructure. As I said in my previous email, only one can set up the block at this stage, the ones coming later will hit busy.