Re: [PATCH nft v9]tests: py: fix pyhton3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 19, 2019 at 11:27:41PM +0530, Shekhar Sharma wrote:
> This patch changes the file to run on both python2 and python3.
> 
> The tempfile module has been imported and used.
> Although the previous replacement of cmp() by eric works, 
> I have replaced cmp(a,b) by ((a>b)-(a<b)) which works correctly.

Any reason not to use Eric's approach? This ((a>b)-(a<b)) is
confusing.

> Thanks!

BTW, strictly place your patch description here.

Things like "Thanks!" to someone specifically and the cmp()
explanation should go below the --- marker, like versioning.

BTW, Cc Eric Garver in your patches, he's helping us with reviewing :-)



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux