On Tue, Jun 18, 2019 at 12:51:13PM +0300, Igor Ryzhov wrote: > Hi Pablo, > > This issue can be seen in the scenario when there are multiple > Contact headers and the first one is using a hostname and other > headers use IP addresses. In this case, ct_sip_walk_headers will > work the following way: > > The first ct_sip_get_header call to will find the first Contact header > but will return -1 as the header uses a hostname. But matchoff will > be changed to the offset of this header. After that, dataoff should be > set to matchoff, so that the next ct_sip_get_header call find the next > Contact header. But instead of assigning dataoff to matchoff, it is > incremented by it, which is not correct, as matchoff is an absolute > value of the offset. So on the next call to the ct_sip_get_header, > dataoff will be incorrect, and the next Contact header may not be > found at all. Thanks for explaining. Would you resubmit a v2 including this description in the patch? Thanks.
