Remove this wrapper, call netlink_list_rules() instead. Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> --- v2: move patch from 5/5 to 4/5. include/netlink.h | 2 +- src/netlink.c | 7 +------ src/rule.c | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/include/netlink.h b/include/netlink.h index 0c08b1abbf6a..279723f33d31 100644 --- a/include/netlink.h +++ b/include/netlink.h @@ -104,6 +104,7 @@ extern struct expr *netlink_alloc_data(const struct location *loc, const struct nft_data_delinearize *nld, enum nft_registers dreg); +extern int netlink_list_rules(struct netlink_ctx *ctx, const struct handle *h); extern void netlink_linearize_rule(struct netlink_ctx *ctx, struct nftnl_rule *nlr, const struct rule *rule); @@ -115,7 +116,6 @@ extern struct chain *netlink_delinearize_chain(struct netlink_ctx *ctx, const struct nftnl_chain *nlc); extern int netlink_list_tables(struct netlink_ctx *ctx, const struct handle *h); -extern int netlink_list_table(struct netlink_ctx *ctx, const struct handle *h); extern struct table *netlink_delinearize_table(struct netlink_ctx *ctx, const struct nftnl_table *nlt); diff --git a/src/netlink.c b/src/netlink.c index a6d81b4f6424..24d8f03ae4be 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -333,7 +333,7 @@ static int list_rule_cb(struct nftnl_rule *nlr, void *arg) return 0; } -static int netlink_list_rules(struct netlink_ctx *ctx, const struct handle *h) +int netlink_list_rules(struct netlink_ctx *ctx, const struct handle *h) { struct nftnl_rule_list *rule_cache; @@ -485,11 +485,6 @@ int netlink_list_tables(struct netlink_ctx *ctx, const struct handle *h) return 0; } -int netlink_list_table(struct netlink_ctx *ctx, const struct handle *h) -{ - return netlink_list_rules(ctx, h); -} - enum nft_data_types dtype_map_to_kernel(const struct datatype *dtype) { switch (dtype->type) { diff --git a/src/rule.c b/src/rule.c index bcd1c0bf73e8..ed199889702f 100644 --- a/src/rule.c +++ b/src/rule.c @@ -191,7 +191,7 @@ static int cache_init_objects(struct netlink_ctx *ctx, enum cmd_ops cmd) if (cmd != CMD_LIST) continue; - ret = netlink_list_table(ctx, &table->handle); + ret = netlink_list_rules(ctx, &table->handle); list_for_each_entry_safe(rule, nrule, &ctx->list, list) { chain = chain_lookup(table, &rule->handle); list_move_tail(&rule->list, &chain->rules); -- 2.11.0