Re: [PATCH nft v2] datatype: fix print of raw numerical symbol values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 17, 2019 at 11:55:42AM +0200, Florian Westphal wrote:
> The two rules:
> arp operation 1-2 accept
> arp operation 256-512 accept
> 
> are both shown as 256-512:
> 
>         chain in_public {
>                 arp operation 256-512 accept
>                 arp operation 256-512 accept
>                 meta mark "1"
>                 tcp flags 2,4
>         }
> 
> This is because range expression enforces numeric output,
> yet nft_print doesn't respect byte order.
> 
> Behave as if we had no symbol in the first place and call
> the base type print function instead.
> 
> This means we now respect format specifier as well:
> 	chain in_public {
>                 arp operation 1-2 accept
>                 arp operation 256-512 accept
>                 meta mark 0x00000001
>                 tcp flags 0x2,0x4
> 	}
> 
> Without fix, added test case will fail:
> 'add rule arp test-arp input arp operation 1-2': 'arp operation 1-2' mismatches 'arp operation 256-512'
> 
> v2: in case of -n, also elide quotation marks, just as if we would not
> have found a symbolic name.
> 
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>

Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Thanks Florian.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux