Re: [PATCH] conntrackd: Use strdup in lexer

Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> · Thu, 30 May 2019 17:02:49 +0200

Hi Ash,

On Mon, May 27, 2019 at 09:59:43PM +0100, Ash Hughes wrote:
> Use strdup in the config file lexer to copy strings to
> yylval.string. This should solve the "[ERROR] unknown layer 3
> protocol" problem here:
> https://www.spinics.net/lists/netfilter/msg58628.html

Thanks, this indeed fixes the problem.

One request below:
> diff --git a/src/read_config_yy.y b/src/read_config_yy.y
> index 1d510ed..1cb9cce 100644
> --- a/src/read_config_yy.y
> +++ b/src/read_config_yy.y
> @@ -117,6 +117,7 @@ logfile_bool : T_LOG T_OFF
>  logfile_path : T_LOG T_PATH_VAL
>  {
>  	strncpy(conf.logfile, $2, FILENAME_MAXLEN);
> +    free($2);
   ^^^^

Could you submit a v2 using 8-char tab indentation instead of spaces?

Thanks!