On Tue, May 28, 2019, 9:36 PM Phil Sutter <phil@xxxxxx> wrote: > > Hi, > > On Tue, May 28, 2019 at 06:06:53AM +0530, Shekhar Sharma wrote: > > This patch converts the run-test.py file to run on both python3 and python2. > > The version history of the patch is: > > v1: modified print and other statments. > > v2: updated the shebang and order of import statements. > > I personally prefer to keep the respin-changelog out of the commit > message, again in a section between commit message and diffstat. My > approach is to rather make sure the commit message itself is up to date > and contains everything relevant worth keeping from the changelog. But > the topic is rather controversial (David Miller e.g. prefers the > changelog as part of the commit message), so you've just read a purely > informational monologue. :) > > > Signed-off-by: Shekhar Sharma <shekhar250198@xxxxxxxxx> > > Acked-by: Phil Sutter <phil@xxxxxx> > > Thanks, Phil Informational monologues like these are very useful to people like me. :-). I very highly value suggestions like these. With regards, Shekhar
