Hi Fernando, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Fernando-Fernandez-Mancera/Extract-SYNPROXY-infrastructure/20190520-153903 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> smatch warnings: net/netfilter/nf_synproxy.c:380 nf_synproxy_ipv4_init() error: uninitialized symbol 'err'. net/netfilter/nf_synproxy.c:803 nf_synproxy_ipv6_init() error: uninitialized symbol 'err'. # https://github.com/0day-ci/linux/commit/6e2622e666e78f7a08abe688716a3edcc2b7e285 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 6e2622e666e78f7a08abe688716a3edcc2b7e285 vim +/err +380 net/netfilter/nf_synproxy.c d918090b Fernando Fernandez Mancera 2019-05-19 367 d918090b Fernando Fernandez Mancera 2019-05-19 368 int nf_synproxy_ipv4_init(struct synproxy_net *snet, struct net *net) d918090b Fernando Fernandez Mancera 2019-05-19 369 { d918090b Fernando Fernandez Mancera 2019-05-19 370 int err; ^^^^^^^ d918090b Fernando Fernandez Mancera 2019-05-19 371 d918090b Fernando Fernandez Mancera 2019-05-19 372 if (snet->hook_ref4 == 0) { ^^^^^^^^^^^^^^^^^^^^ Assume this is false. d918090b Fernando Fernandez Mancera 2019-05-19 373 err = nf_register_net_hooks(net, ipv4_synproxy_ops, d918090b Fernando Fernandez Mancera 2019-05-19 374 ARRAY_SIZE(ipv4_synproxy_ops)); d918090b Fernando Fernandez Mancera 2019-05-19 375 if (err) d918090b Fernando Fernandez Mancera 2019-05-19 376 return err; d918090b Fernando Fernandez Mancera 2019-05-19 377 } d918090b Fernando Fernandez Mancera 2019-05-19 378 d918090b Fernando Fernandez Mancera 2019-05-19 379 snet->hook_ref4++; d918090b Fernando Fernandez Mancera 2019-05-19 @380 return err; ^^^ d918090b Fernando Fernandez Mancera 2019-05-19 381 } d918090b Fernando Fernandez Mancera 2019-05-19 382 EXPORT_SYMBOL_GPL(nf_synproxy_ipv4_init); d918090b Fernando Fernandez Mancera 2019-05-19 383 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
