Hi, On Fri, May 3, 2019 at 9:02 AM Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx> wrote: > >>> Let's use nfgenmsg->version for this. This is so far set to zero. We > >>> can just update userspace to set it to 1, so family is used. > >>> > >>> The version field in the kernel size is ignored so far, so this should > >>> be enough. So we avoid that extract netlink attribute. > >> > >> Why making such a hack? If any userspace app set this field (simply because it's > >> not initialized), it will show up a new regression. > >> What is the problem of adding another attribute? > > > > The version field was meant to deal with this case. > > > > It has been not unused so far because we had no good reason. > > > Fair point, agreed. Great that the discussion has reached a conclusion. I will prepare a fix based on the version-filed and submit it either later today or during the weekend. Sorry again for the problems my change caused. BR, Kristian
