On Sat, Apr 13, 2019 at 11:23:26PM +0200, Florian Westphal wrote: > net/netfilter/nf_nat_core.c:422:29: sparse: incorrect type in assignment (different base types) > net/netfilter/nf_nat_core.c:422:29: expected unsigned int [unsigned] [assigned] min > net/netfilter/nf_nat_core.c:422:29: got restricted __be16 const [usertype] id > > The warning is correct, this needs ntohs treatment. > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > Fixes: 203f2e78200c27e ("netfilter: nat: remove l4proto->unique_tuple") > Signed-off-by: Florian Westphal <fw@xxxxxxxxx> > --- > Pablo, feel free to squash this with commit 57be8a51f2a8ba390f7c5a03d2ae812a1b39c9bb > ("netfilter: nat: fix icmp id randomization"), it touched this area > already (and moved the faulty line to its current place). I have collapsed it as suggested. Thanks.