On Thu, Apr 04, 2019 at 02:01:23PM +0200, Pablo Neira Ayuso wrote:
> Cc'ing Duncan, he's been helping with reviewing documentation.
>
> On Thu, Apr 04, 2019 at 01:41:58PM +0200, Fernando Fernandez Mancera wrote:
> > Signed-off-by: Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx>
> > ---
> > doc/nft.txt | 13 +++++++++----
> > 1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/nft.txt b/doc/nft.txt
> > index d162dad..36a92fe 100644
> > --- a/doc/nft.txt
> > +++ b/doc/nft.txt
> > @@ -256,6 +256,7 @@ TABLES
> > [verse]
> > {add | create} *table* ['family'] 'table' [ {flags 'flags'} ]
> > {delete | list | flush} *table* ['family'] 'table'
> > +list *tables*
> > delete *table* ['family'] handle 'handle'
> >
> > Tables are containers for chains, sets and stateful objects. They are identified
> > @@ -266,7 +267,8 @@ nfproto* keyword can be used to test which family (ipv4 or ipv6) context the
> > packet is being processed in. When no address family is specified, *ip* is used
> > by default. The only difference between add and create is that the former will
> > not return an error if the specified table already exists while *create* will
> > -return an error.
> > +return an error. The plural form of list can be used to list all the existing
> > +tables.
>
> Not sure we need this sentence, I mean, not sure if reader will
> correlate this with 'list tables'.
>
> Probably just adding:
>
> list *tables*
>
> and so on, for other objects in the [verse] area is just enough.
>
> Thanks!
Hi Pablo,
I had no trouble understanding the sentence, but wouldn't it be clearer to
change it to simply
*list tables* lists all the existing tables.
Sorry for late reply - a bit behind with my emails.
Cheers ... Duncan.
