Re: [PATCH nft 2/2 v2] configure.ac: Clean up AC_ARG_{WITH,ENABLE} invocations, s/==/=/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 17, 2019 at 07:24:22PM +0100, Luis Ressel wrote:
> * AC_ARG_ENABLE implicitly defines enable_debug; there's no point in
>   performing extra work just to define with_debug with an identical
>   value.
> 
> * The same applies to with_xtables and with_libxtables.
> 
> * The AS_IF block in the `AC_ARG_ENABLE([man-doc], ...` invocation is
>   essentially a noop. All it does is to set enable_man_doc to `yes` if
>   has a value that matches neither `yes` nor `no`. (This could happen if
>   a user calls `configure --enable-man-doc=foo`, but that'd be a user
>   error which we don't need to handle.)
> 
> * The correct operator for equality tests in `test` is `=`. Some
>   implementations also support `==`, but this is not portable.

Also applied, thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux