Re: [PATCH nf] netfilter: nf_tables: return immediately on empty commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> term1# nft add table x
> term1# nft add table x
> 
> term2# nft monitor
> add table ip x
> # new generation 1587 by process 14422 (nft)
> # new generation 1588 by process 14423 (nft)
> 
> So re-insertion of existing objects should not trigger unnecessary
> generation counter bump. We can probably count the number of events
> that have been sent from the commit path before we bump it.

Thats strange.  Why does the second add result in the creation
of a transaction object in the first place?

2nd add should result in a call to "upd_table", and it should
find that no attributes are being changed, and no transaction
object should be created, i.e. the commit should end up with
empty transaction list.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux